Skip to content

[FIXED] Trusted Proxies: Reload log message report added keys as removed#7427

Merged
neilalexander merged 1 commit intomainfrom
fix_trusted_proxies_reload_log
Oct 14, 2025
Merged

[FIXED] Trusted Proxies: Reload log message report added keys as removed#7427
neilalexander merged 1 commit intomainfrom
fix_trusted_proxies_reload_log

Conversation

@kozlovic
Copy link
Copy Markdown
Member

When doing a configuration reload and some keys are removed, there is a log message such as:

Reloaded: proxies trusted keys ["xxx", "yyy"] were removed

However, the list contains the added keys, not the removed ones. The log statement about the added ones is correct.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

When doing a configuration reload and some keys are removed, there
is a log message such as:
```
Reloaded: proxies trusted keys ["xxx", "yyy"] were removed
```
However, the list contains the added keys, not the removed ones.
The log statement about the added ones is correct.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from a team as a code owner October 14, 2025 00:07
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@neilalexander neilalexander merged commit 6405f2b into main Oct 14, 2025
89 of 92 checks passed
@neilalexander neilalexander deleted the fix_trusted_proxies_reload_log branch October 14, 2025 08:39
neilalexander added a commit that referenced this pull request Oct 14, 2025
Includes the following:

- #7427 
- #7428
- #7429 
- #7431

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants