Skip to content

Add linux/arm64 to nightly, make it multiplatform#7263

Closed
wallyqs wants to merge 1 commit intomainfrom
multi-nightly
Closed

Add linux/arm64 to nightly, make it multiplatform#7263
wallyqs wants to merge 1 commit intomainfrom
multi-nightly

Conversation

@wallyqs
Copy link
Copy Markdown
Member

@wallyqs wallyqs commented Sep 5, 2025

Makes nightly multi platform and add support for arm64 which we use more in testing lately.

Generates:

  • Single

    • synadia/nats-server:nightly-amd64
    • synadia/nats-server:nightly-arm64
    • synadia/nats-server:nightly-20250905-amd64
    • synadia/nats-server:nightly-20250905-arm64
  • Multi

    • synadia/nats-server:nightly (both amd64 and arm64)
    • synadia/nats-server:nightly-20250905

Signed-off-by: Waldemar Quevedo wally@nats.io

@wallyqs wallyqs requested a review from a team as a code owner September 5, 2025 17:09
Copy link
Copy Markdown
Member

@samuelattwood samuelattwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander
Copy link
Copy Markdown
Member

neilalexander commented Sep 8, 2025

I'm fine with adding the ARM64 builds but I don't see much use in the -amd64 and -arm64 tag prefixes, Docker should only pull the right layers for the right architecture regardless.

Copy link
Copy Markdown
Member

@philpennock philpennock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a choice. We can switch to requiring the newest GoReleaser and drop the need for the -{platform_arch} suffices, or we can accept that this works as-is and seems to be based on the well-tested flow used for Synadia's commercial builds for some time and which the open source project is welcome to use.

I think this is fine as-is, but we should plan on trying out the new GoReleaser functionality "sometime soon". We don't guarantee the availability of the platform variants, it's an implementation detail and we can freely withdraw it. If it breaks for someone, they were doing something silly with open source and we're not obligated to support them.

So I'm approving as-is, but won't object to changes to avoid the arch.

@neilalexander
Copy link
Copy Markdown
Member

I would prefer we get multi-arch images right rather than having new suffixes and breaking an established naming convention.

@samuelattwood
Copy link
Copy Markdown
Member

In my view this doesn't break established naming, the multi-arch manifest remains and is how this will typically be pulled, it just also gives a tag to the underlying SHAs that the manifest references. This is a pretty typical approach with GoReleaser.

@neilalexander neilalexander force-pushed the multi-nightly branch 2 times, most recently from 1d256ad to 26012b7 Compare September 29, 2025 09:50
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants