Skip to content

[IMPROVED] CI: Check PR sign-offs with env variable #7033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilalexander merged 1 commit into from
Jul 3, 2025
Merged

[IMPROVED] CI: Check PR sign-offs with env variable #7033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ jobs:

- name: Check PR description is signed off
if: github.event_name == 'pull_request'
env:
PR_DESC: ${{ github.event.pull_request.body }}
run: |
if ! echo "${{ github.event.pull_request.body }}" | grep -Pq '^Signed-off-by:\s*(?!Your Name|.*<your\.email@example\.com>)'; then
if ! echo "$PR_DESC" | grep -Pq '^Signed-off-by:\s*(?!Your Name|.*<your\.email@example\.com>)'; then
Copy link
Copy Markdown

@robinbowes robinbowes Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use something like this instead:

[[ ${{ github.event.pull_request.body }} =~ ^Signed-off-by:\s*(?!Your Name|.*<your\.email@example\.com>) ]] || (
  echo "::error ::Pull request has not been signed off in the PR description with a \`Signed-off-by:\` line"
  exit 1
)

echo "::error ::Pull request has not been signed off in the PR description with a \`Signed-off-by:\` line"
exit 1
fi
Expand Down
Loading