Closed
Conversation
neilalexander
requested changes
Apr 18, 2025
README.md
Outdated
|
|
||
| A third party security audit was performed by Cure53, you can see the full report [here](https://github.com/nats-io/nats-general/blob/main/reports/Cure53_NATS_Audit.pdf). | ||
| A third-party security audit was performed by ostif.org with the help of "Trail of Bits". | ||
| You can see the full report [on Trail of Bit’s Github](https://github.com/trailofbits/publications/blob/master/reviews/2025-04-ostif-nats-securityreview.pdf). |
Member
There was a problem hiding this comment.
"Trail of Bits GitHub", no apostrophe. Can just change the link to "here"?
Member
Author
There was a problem hiding this comment.
I personally like longer links because I think 4 chars are easier to miss, but I can change if you insist :-)
Member
There was a problem hiding this comment.
I suggest linking to the blog post and the report directly. A compromise would be be two links that are named and have purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Bozhenko alex@synadia.com