Skip to content

Cherry-picks for 2.10.26-RC.2#6489

Merged
neilalexander merged 11 commits intorelease/v2.10.26from
neil/21026rc2
Feb 10, 2025
Merged

Cherry-picks for 2.10.26-RC.2#6489
neilalexander merged 11 commits intorelease/v2.10.26from
neil/21026rc2

Conversation

neilalexander and others added 11 commits February 10, 2025 10:09
[ci skip]

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
By calculating the write deadline at the beginning of the flush operation,
we could be hitting it early if there is a lot of data queued up. Instead
this PR applies it to each `writev` batch of at most 1024 vectors, which
means that the deadline applies to no more than 64MB in one go.

This makes it simpler to tune the write deadline as it can be thought of
as "the maximum time taken to allow writing at most 64MB" instead.

Signed-off-by: Neil Twigg <neil@nats.io>
This should hopefully de-flake this test by ensuring we send enough
requests that we can't possibly interleave with a listening worker.

Signed-off-by: Neil Twigg <neil@nats.io>
…, make sure to add in to account stats the sent msgs and bytes to replicate.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner February 10, 2025 14:48
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit e84fbdc into release/v2.10.26 Feb 10, 2025
@neilalexander neilalexander deleted the neil/21026rc2 branch February 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants