Merged
Conversation
Member
Author
|
Seems the test can still flake, turning into draft for a bit. |
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/de-flake-state-adder
branch
from
98477a8 to
00f3b5f
Compare
Member
Author
|
Seems to not flake anymore after adding a call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
TestNRGHeartbeatOnLeaderChangeby checking if new entries are actually being applied. This was not possible before because it would always check a total of 0. If all proposals would fail, this test would still pass.More importantly
a.sumwas not reset, which meant that state before the call torestart()would be preserved, and replayed entries during catchup/recovery would be re-applied.Also added a call to
a.n.WaitForStop()ina.stop(). Otherwise things could still be around and not properly stopped when we restart witha.restart().Signed-off-by: Maurice van Veen github@mauricevanveen.com