Merged
Conversation
Previous behaviour of checking interface is `nil` didn't do the right thing as a `nil` parameter could still be wrapped in an interface descriptor that itself would be non-`nil`, so use reflection instead. Signed-off-by: Neil Twigg <neil@nats.io>
There were various things wrong with this test: 1. The routes between S1 and S2 were only slow in one direction 2. The stream listened for one subject and then the publisher published on another 3. The final `checkFor` didn't wait to see if all of the messages had even been processed before going on to check preack state Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/requirenotnil
branch
from
c88d9d4 to
44c32ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous behaviour of checking interface is
nildidn't do the right thing as anilparameter could still be wrapped in an interface descriptor that itself would be non-nil, so use reflection instead.Signed-off-by: Neil Twigg neil@nats.io