Skip to content

WebSocket: Ensure full writes to compressor#6091

Merged
derekcollison merged 1 commit intomainfrom
neil/wsreaders
Nov 14, 2024
Merged

WebSocket: Ensure full writes to compressor#6091
derekcollison merged 1 commit intomainfrom
neil/wsreaders

Conversation

@neilalexander
Copy link
Copy Markdown
Member

The cp.Write() call may have been partial and we would not have noticed.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner November 8, 2024 12:45
Comment thread server/websocket.go Outdated
Comment thread server/websocket.go
Comment thread server/websocket.go
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 2b8d891 into main Nov 14, 2024
@derekcollison derekcollison deleted the neil/wsreaders branch November 14, 2024 15:41
neilalexander added a commit that referenced this pull request Nov 19, 2024
Includes the following:

* #6121
* #6122
* #6126
* #6127
* #6128
* #6091
* #6132
* #6133
* #6135

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants