Cherry-picks for 2.10.23-RC.1#6054
Merged
neilalexander merged 16 commits intorelease/v2.10.23from Oct 29, 2024
Merged
Conversation
Signed-off-by: Colin Sullivan <colin@luxantsolutions.com>
This should allow access to `CERT_SYSTEM_STORE_LOCAL_MACHINE` from non-admin users. Fixes #6018. Signed-off-by: Neil Twigg <neil@nats.io>
Otherwise a lot of allocations escape to the heap due to the `json.Unmarshal()`. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
When receiving a message from a route, if the queue interest is only routes and leaf connections, the server will always favor the leaf kind. However, if there were more than one leaf connections for the same queue group, the server will always pick the same (the last one). It would change if new leaf were to connect or disconnect/reconnect, but with a stable set, it would always be the same. This PR makes this selection somewhat random. Resolves #6040 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Many of these are already defined so we don't need such a long list of magic numbers. Signed-off-by: Neil Twigg <neil@nats.io>
Input value should be hex-encoded string of the SHA1 thumbprint. See: #6024 Signed-off-by: Neil Twigg <neil@nats.io>
Replaces #4384. Co-authored-by: Daniel Modler <modler@linkbit.io> Co-authored-by: Neil Twigg <neil@nats.io> Signed-off-by: Neil Twigg <neil@nats.io>
…oded form Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following:
CERT_STORE_READONLY_FLAGwhen opening cert stores #6019thumbprintin the Windows certificate store #6047hasFWC#6049Signed-off-by: Neil Twigg neil@nats.io