Skip to content

Fix data race in TestNRGTermDoesntRollBackToPtermOnCatchup #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derekcollison merged 1 commit into from
Oct 11, 2024
Merged

Fix data race in TestNRGTermDoesntRollBackToPtermOnCatchup #5991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/raft_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,8 @@ func TestNRGTermDoesntRollBackToPtermOnCatchup(t *testing.T) {
require_Equal(t, rn.pindex, 6)
}
}
// This will make followers run a catchup.
ae := newAppendEntry(leader.id, leader.term, leader.commit, leader.pterm, leader.pindex, nil)
rg.unlockAll()

arInbox := nc.NewRespInbox()
Expand All @@ -800,7 +802,6 @@ func TestNRGTermDoesntRollBackToPtermOnCatchup(t *testing.T) {
// In order to trip this condition, we need to send an append entry that
// will trick the followers into running a catchup. In the process they
// were setting the term back to pterm which is incorrect.
ae := newAppendEntry(leader.id, leader.term, leader.commit, leader.pterm, leader.pindex, nil)
b, err := ae.encode(nil)
require_NoError(t, err)
require_NoError(t, nc.PublishMsg(&nats.Msg{
Expand Down