Fix some missing mutex unlocks in filestore and streams

server/filestore.go

@@ -4320,24 +4320,28 @@ func (mb *msgBlock) truncate(sm *StoreMsg) (nmsgs, nbytes uint64, err error) {
 	if mb.cmp != NoCompression {
 		buf, err := mb.loadBlock(nil)
 		if err != nil {
+			mb.mu.Unlock()
 			return 0, 0, fmt.Errorf("failed to load block from disk: %w", err)
 		}
 		if mb.bek != nil && len(buf) > 0 {
 			bek, err := genBlockEncryptionKey(mb.fs.fcfg.Cipher, mb.seed, mb.nonce)
 			if err != nil {
+				mb.mu.Unlock()
 				return 0, 0, err
 			}
 			mb.bek = bek
 			mb.bek.XORKeyStream(buf, buf)
 		}
 		buf, err = mb.decompressIfNeeded(buf)
 		if err != nil {
+			mb.mu.Unlock()
 			return 0, 0, fmt.Errorf("failed to decompress block: %w", err)
 		}
 		buf = buf[:eof]
 		copy(mb.lchk[0:], buf[:len(buf)-checksumSize])
 		buf, err = mb.cmp.Compress(buf)
 		if err != nil {
+			mb.mu.Unlock()
 			return 0, 0, fmt.Errorf("failed to recompress block: %w", err)
 		}
 		meta := &CompressionInfo{
@@ -4348,16 +4352,19 @@ func (mb *msgBlock) truncate(sm *StoreMsg) (nmsgs, nbytes uint64, err error) {
 		if mb.bek != nil && len(buf) > 0 {
 			bek, err := genBlockEncryptionKey(mb.fs.fcfg.Cipher, mb.seed, mb.nonce)
 			if err != nil {
+				mb.mu.Unlock()
 				return 0, 0, err
 			}
 			mb.bek = bek
 			mb.bek.XORKeyStream(buf, buf)
 		}
 		n, err := mb.writeAt(buf, 0)
 		if err != nil {
+			mb.mu.Unlock()
 			return 0, 0, fmt.Errorf("failed to rewrite compressed block: %w", err)
 		}
 		if n != len(buf) {
+			mb.mu.Unlock()
 			return 0, 0, fmt.Errorf("short write (%d != %d)", n, len(buf))
 		}
 		mb.mfd.Truncate(int64(len(buf)))
@@ -7008,6 +7015,7 @@ func (fs *fileStore) Truncate(seq uint64) error {
 	// Set lmb to nlmb and make sure writeable.
 	fs.lmb = nlmb
 	if err := nlmb.enableForWriting(fs.fip); err != nil {
+		fs.mu.Unlock()
 		return err
 	}
 

server/stream.go

@@ -5611,6 +5611,7 @@ func (mset *stream) swapSigSubs(o *consumer, newFilters []string) {
 
 	if o.closed || o.mset == nil {
 		o.mu.Unlock()
+		mset.clsMu.Unlock()
 		return
 	}