Skip to content

[FIXED] Make sure to properly handle filtered purges with consumers that have a wider filtered subject.#5075

Merged
derekcollison merged 1 commit into
mainfrom
filtered-purge-nap
Feb 13, 2024
Merged

[FIXED] Make sure to properly handle filtered purges with consumers that have a wider filtered subject.#5075
derekcollison merged 1 commit into
mainfrom
filtered-purge-nap

Conversation

@derekcollison
Copy link
Copy Markdown
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison derekcollison requested a review from a team as a code owner February 13, 2024 21:39
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle (but looks like a test is failing?)

…der filtered subject.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison changed the title [FIXED] Make sure to properly set first and match for consumers that match all for filtered purge. [FIXED] Make sure to properly handle filtered purges with consumers that have a wider filtered subject. Feb 13, 2024
Copy link
Copy Markdown
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekcollison derekcollison merged commit d549b4a into main Feb 13, 2024
@derekcollison derekcollison deleted the filtered-purge-nap branch February 13, 2024 23:51
wallyqs added a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants