Open
Conversation
Member
|
@jevolk could you try to change the target to be the dev branch? There would only be a minor conflict in const.go |
27252ec to
ddfe7cb
Compare
ddfe7cb to
9616e1f
Compare
Removes hardcoded global; resolves FIXME. Signed-off-by: Jason Volk <jason@zemos.net>
9616e1f to
a113283
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes hardcoded global; resolves FIXME.
Resolves #NNNgit pull --rebase origin main)Resolves
nats-server/server/events.go
Lines 83 to 84 in 039f63e
Tangentially related to #4227 #4234