Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Allow bearer token as mqtt authentication method #1840

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

angiglesias
Copy link
Contributor

Changes proposed in this pull request:

  • Allow parsing password field on MQTT Connect request as a JWT to use bearer token client authentication/authorization

Tests added

  • Test MQTT authentication with tokens with different "allowed connection types" to ensure correct user authorization

/cc @nats-io/core

…ents

Signed-off-by: Ángel <angelo.fly1@gmail.com>
@angiglesias angiglesias changed the title [ADDED] Allow bearer token as mqtt authentication [ADDED] Allow bearer token as mqtt authentication method Jan 25, 2021
@angiglesias angiglesias marked this pull request as ready for review January 25, 2021 17:41
@angiglesias angiglesias force-pushed the allow-mqtt_bearer_token branch from 1fba88e to 8e56bea Compare January 25, 2021 17:44
Signed-off-by: Ángel <angelo.fly1@gmail.com>
@angiglesias angiglesias force-pushed the allow-mqtt_bearer_token branch from 8e56bea to 07c3214 Compare January 25, 2021 17:44
@kozlovic
Copy link
Member

@angiglesias Thank you for your contribution! I was planning on doing just that, so thanks! I will have a look later today.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! This approach will allow user to use MQTT clients with NATS operator mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants