Add Windows Server LTSC 2022 builds, deprecate Windows 1809 builds#240
Merged
neilalexander merged 1 commit intomainfrom Jun 2, 2025
Merged
Add Windows Server LTSC 2022 builds, deprecate Windows 1809 builds#240neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
neilalexander
force-pushed
the
neil/ltsc2022
branch
5 times, most recently
from
36fd3bc to
89b61f9
Compare
Signed-off-by: Neil Twigg <neil@nats.io> Co-authored-by: Neil Twigg <neil@nats.io> Co-authored-by: Byron Ruth <byron@nats.io> Logs pls Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/ltsc2022
branch
from
f15a83d to
6cc97b1
Compare
neilalexander
changed the title
philpennock
approved these changes
Jun 2, 2025
Member
There was a problem hiding this comment.
Minor concern about moving permissions back up to the parent scope but since there wasn't an explicit permissions block there, it meant that new jobs would have had default permissions, not the limited ones desired. Since all the jobs in that file were the same [edit: same sort of thing, same role, didn't mean identical, sorry] and it doesn't seem too likely that we'll add other jobs which aren't the same basic flow, I think this migration is defensible, so LGTM for that too.
The rest all seemed to make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #153, fixes #106. Related to docker-library/official-images#19138.
There's also scaffolding here to support LTSC 2025, but at present it is not used. The NATS Server panics at startup on LTSC 2025 and that needs to be addressed first.
Signed-off-by: Neil Twigg neil@nats.io