❓ Coerce rollbar config path to a string #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 33 33
Lines 1418 1418
Branches 226 226
=======================================
Hits 1329 1329
Misses 69 69
Partials 20 20 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/rollbar/__init__.py", line 1026, in _add_locals_data
if arginfo.locals and _check_add_locals(cur_frame, frame_num, num_frames):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/rollbar/__init__.py", line 1129, in _check_add_locals
('root' in SETTINGS and (frame.get('filename') or '').lower().startswith((SETTINGS['root'] or '').lower()))))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'PosixPath' object has no attribute 'lower'
rollbar/pyrollbar#345 suggests this is caused by rollbar reciving a PosixPath not a string, so we coerce it before passing it to the config.
dragon-dxw
force-pushed
the
force-rollbar-root-to-be-string-not-path
branch
from
17e58b5
to
ec9897c
Compare
anthonyhashemi
approved these changes
Aug 24, 2023
jacksonj04
approved these changes
Aug 24, 2023
dragon-dxw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have regular issues with errors ending in:
rollbar/pyrollbar#345 suggests this is caused by rollbar reciving a PosixPath not a string, so we coerce it before passing it to the config.