Fix for Force Charge not working when using H1 over LAN #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like a bug has crept in on the later releases when trying to set force charge for H1 using LAN. H1 LAN doesn't support work mode hence it is not possible to set a fall back mode and the 'assert if work_mode_map is not None' correctly raises an error for H1 LAN.
|
See #670 |
fix black lint
canton7
requested changes
Sep 3, 2024
|
Thank you! |
correct code structure
ahh that's why it's there to avoid mypy fail
fix for black linting fail
|
@canton7 sorry that was a bit of a chore for such a small change, linting finally passes….. (I’ve tested to confirm it works as expected) - over to you |
|
Thanks! Apologies for being so slow, I'm back now :) |
canton7
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a bug has crept in on the later releases when trying to set force charge for H1 using LAN.
H1 LAN doesn't support work mode hence it is not possible to set a fall back mode and the 'assert if work_mode_map is not None' correctly raises an error for H1 LAN.