Add Python 3.12 compatibility, drop Python 3.7 (EOL) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurcher
force-pushed
the
setuptools
branch
6 times, most recently
from
e1fd707
to
771b7e5
Compare
zurcher
changed the title
|
Python 3.7 is EOL: |
|
Thank you once again! 🥳 Sorry for the delay releasing the upcoming package! |
nathanhi
previously approved these changes
Oct 15, 2023
|
Seems like the tests are failing in Python 3.12 due to the usage of deprecated / removed test methods in PyFilesystem2: PyFilesystem/pyfilesystem2#568 I've added a workaround until this gets fixed upstream. |
nathanhi
approved these changes
Oct 15, 2023
|
Thanks for cleaning this up! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the following error when installing from source with
pip install -e:AttributeError: module 'pkgutil' has no attribute 'ImpImporter'.Tested with Python 3.12 and 3.10.11.