Restore original iterator for non-lazy load #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's my test code for exercising the copy_dir and tree APIs. |
The modified iterator causes failure of FileSystem.tree() and copy_dir() APIs which become apparent when opening a new filesystem and comparing the directory tree
|
Awesome, thank you once again for your contribution! Sorry to keep you waiting with reviewing your changes. I've taken the liberty of updating the tests and updating the changelog. |
nathanhi
approved these changes
Jul 9, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modified iterator causes failure of FileSystem.tree() and copy_dir() APIs, possibly more.