Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reqwest with ureq #57

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Nov 4, 2024

This removes around 750 lines of dependencies from Cargo.lock (see e9e4b25), making ffmpeg-sidecar compile faster.
The code is also shorter.

I also added Cargo.lock to git, for predictable builds (important for e.g. git bisect, and also to prevent CI from failing just because some 3rd party crate made some change). See https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html for more.

Oh, and thanks for an awesome crate 🙏

Copy link
Owner

@nathanbabcock nathanbabcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite happy with the improvement in build times on this PR. ureq looks like a great fit.

Thank you for the nice find and the kind words. Also the tips about library best practices are appreciated too. 😎

@nathanbabcock nathanbabcock merged commit b180240 into nathanbabcock:main Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants