Small code cleanup & fix CodeQA alerts.

nathan130200 · May 11, 2024 · d39d9a4 · d39d9a4
1 parent da1838e
commit d39d9a4
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 25 deletions.
diff --git a/XmppSharp/Dom/Element.cs b/XmppSharp/Dom/Element.cs
@@ -1,7 +1,5 @@
 using System.Globalization;
-using System.Security;
 using System.Text;
-using System.Web;
 using System.Xml;
 using XmppSharp.Factory;
 
@@ -223,7 +221,6 @@ internal void WriteToInternal(XmlWriter writer, in XmlFormatting formatting, boo
 
 		if (includeChildren)
 		{
-
 			lock (this._childNodes)
 			{
 				foreach (var node in this._childNodes)

diff --git a/XmppSharp/Parsers/XmppStreamParser.cs b/XmppSharp/Parsers/XmppStreamParser.cs
@@ -1,6 +1,4 @@
-using System.Runtime.CompilerServices;
-using System.Text;
-using System.Xml;
+using System.Xml;
 using System.Xml.Schema;
 using XmppSharp.Exceptions;
 using XmppSharp.Factory;

diff --git a/XmppSharp/Protocol/Sasl/Abort.cs b/XmppSharp/Protocol/Sasl/Abort.cs
@@ -1,5 +1,4 @@
-using System.Xml.Linq;
-using XmppSharp.Attributes;
+using XmppSharp.Attributes;
 
 namespace XmppSharp.Protocol.Sasl;
 

diff --git a/XmppSharp/Protocol/Sasl/Challenge.cs b/XmppSharp/Protocol/Sasl/Challenge.cs
@@ -1,5 +1,4 @@
-using System.Xml.Linq;
-using XmppSharp.Attributes;
+using XmppSharp.Attributes;
 
 namespace XmppSharp.Protocol.Sasl;
 

diff --git a/XmppSharp/Protocol/Sasl/Failure.cs b/XmppSharp/Protocol/Sasl/Failure.cs
@@ -1,5 +1,4 @@
-using System.Xml.Linq;
-using XmppSharp.Attributes;
+using XmppSharp.Attributes;
 
 namespace XmppSharp.Protocol.Sasl;
 

diff --git a/XmppSharp/Protocol/Sasl/Mechanism.cs b/XmppSharp/Protocol/Sasl/Mechanism.cs
@@ -1,5 +1,4 @@
-using System.Xml.Linq;
-using XmppSharp.Attributes;
+using XmppSharp.Attributes;
 
 namespace XmppSharp.Protocol.Sasl;
 

diff --git a/XmppSharp/TryParseHelpers.cs b/XmppSharp/TryParseHelpers.cs
@@ -39,12 +39,7 @@ public static class TryParseHelpers
 	};
 
 	public static Delegate GetConverter(Type type)
-	{
-		if (_typeMap.TryGetValue(type, out var func))
-			return func;
-
-		else return null;
-	}
+		=> _typeMap.TryGetValue(type, out var func) ? func : null;
 
 	/// <summary>
 	/// Parser implementation for the <see cref="System.UInt16"/> type.

diff --git a/XmppSharp/Xml.cs b/XmppSharp/Xml.cs
@@ -1,5 +1,4 @@
 using System.Globalization;
-using System.Net.Http.Headers;
 using System.Text;
 using System.Xml;
 using XmppSharp.Parser;
@@ -37,14 +36,14 @@ public static XmlQualifiedName ExtractQualifiedName(string source)
 		};
 	}
 
-	public static async Task<Element> FromStringAsync(string xml, CancellationToken token = default)
+	public static async Task<Element> ParseFromStringAsync(string xml, CancellationToken token = default)
 	{
 		using (var ms = new MemoryStream(xml.GetBytes()))
 		using (var parser = new XmppStreamParser(ms))
 			return await parser.GetNextElementAsync(token);
 	}
 
-	public static async Task<Element> FromStreamAsync(Stream stream, CancellationToken token = default)
+	public static async Task<Element> ParseFromStreamAsync(Stream stream, CancellationToken token = default)
 	{
 		using (var parser = new XmppStreamParser(stream))
 			return await parser.GetNextElementAsync(token);

diff --git a/XmppSharp/XmlFormatting.cs b/XmppSharp/XmlFormatting.cs
@@ -1,5 +1,4 @@
-using System.Diagnostics;
-using System.Xml;
+using System.Xml;
 
 namespace XmppSharp;