This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 215
Introduce automated tests, de-lint, and migrate towards best practices #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @bugeats |
Great! I'll be involved for at least as long as it takes for you to pick back up on the project, and I'll let you know how conditional formatting is coming. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nater. I've been using this library for a professional project and it's been very helpful. Thank you for all your hard work.
My project requires conditional formatting, and I'm planning on taking a stab at implementing it. In order to do this, I needed to get some automated tests going.
I was also having trouble with JS bundling, so I de-linted the project and migrated towards some best practices (like lower-case file names).
There's a lot here, but the underlying code should't have changed much.
I added an eslintrc file. Of course, style is often a matter of personal preference, but in this case I strive to model it off the latest JS style guides. If you have an editor that supports eslint, I highly recommend using it.
You can run tests with:
npm test
. The quicker that tests are completed, the sooner we can be confident about correct implementation of conditional formatting.Thanks,
-C