Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Introduce automated tests, de-lint, and migrate towards best practices #52

Merged
merged 22 commits into from
Jan 8, 2016

Conversation

bugeats
Copy link
Contributor

@bugeats bugeats commented Jan 8, 2016

Hi Nater. I've been using this library for a professional project and it's been very helpful. Thank you for all your hard work.

My project requires conditional formatting, and I'm planning on taking a stab at implementing it. In order to do this, I needed to get some automated tests going.

I was also having trouble with JS bundling, so I de-linted the project and migrated towards some best practices (like lower-case file names).

There's a lot here, but the underlying code should't have changed much.

I added an eslintrc file. Of course, style is often a matter of personal preference, but in this case I strive to model it off the latest JS style guides. If you have an editor that supports eslint, I highly recommend using it.

You can run tests with: npm test. The quicker that tests are completed, the sooner we can be confident about correct implementation of conditional formatting.

Thanks,
-C

@natergj natergj merged commit 84b25b1 into natergj:master Jan 8, 2016
@natergj
Copy link
Owner

natergj commented Jan 8, 2016

Thanks @bugeats
I've been meaning to add testing linting for a while now. This was an extremely useful pull request. It's been published to npmjs.com under version 0.3.0. There are few features I'm hoping to start on after a big application update release at work is complete in a couple weeks. Among them are ability to add comments to a cell, get detailed information about a cell, bulk data population from SQL query and importing a template file. Conditional formatting has been requested a few times, so I'm very glad to hear you're working on that.
Thanks, again!
nater

@bugeats
Copy link
Contributor Author

bugeats commented Jan 8, 2016

Great! I'll be involved for at least as long as it takes for you to pick back up on the project, and I'll let you know how conditional formatting is coming.

@bugeats bugeats deleted the cleanup-and-tests branch January 8, 2016 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants