Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

[issue 283] fix comment drawing changing after save #284

Merged
merged 1 commit into from
Apr 28, 2019
Merged

[issue 283] fix comment drawing changing after save #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/lib/worksheet/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,8 @@ let commentsXML = (ws) => {

let commentsVmlXML = (ws) => {
return new Promise((resolve, reject) => {
const vmlXml = xml.create('xml');
// do not add XML prolog to document
const vmlXml = xml.begin().ele('xml');
vmlXml.att('xmlns:v', 'urn:schemas-microsoft-com:vml')
vmlXml.att('xmlns:o', 'urn:schemas-microsoft-com:office:office');
vmlXml.att('xmlns:x', 'urn:schemas-microsoft-com:office:excel');
Expand All @@ -649,7 +650,7 @@ let commentsVmlXML = (ws) => {
.att('o:spt', '202')
.att('path', 'm,l,21600r21600,l21600,xe');
st.ele('v:stroke').att('joinstyle', 'miter');
st.ele('v:path').att('gradientshapeok', 't').att('o:connectortype', 'rect');
st.ele('v:path').att('gradientshapeok', 't').att('o:connecttype', 'rect');

Object.keys(ws.comments).forEach((ref) => {
const {row, col, position, marginLeft, marginTop, width, height, zIndex, visibility, fillColor} = ws.comments[ref];
Expand Down