This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Allow to use with bundler #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @mantoni! This makes sense and I was looking to implement this change in the v2 release, anyways. I'll try to get a new patch version published to NPM soon. I'm going to try to squeeze in another bug fix into that release first. Hopefully this week. |
|
Thanks for merging! If you could release a patch with this it would help me greatly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this nice library. I found it easy to get started with.
I'm deploying this in an AWS Lambda function. To reduce cold start time, I'm using a bundler to jam all JS into a single file. The bundler isn't able to resolve the dynamic module loading that is used in
source/lib/types/index.js.This was the only place I found and with this change, it works great.