Sync using 'upload_folder' + add private attribute #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thank you so much!! Will check out this PR asap |
nateraw
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nateraw I made a few changes/fixes if that's fine with you. Love the idea of this Github Action btw 🔥.
privateargument was described in README but not effective in the github actionrepo_idcan be misleading if username is implicit => I still wonder how we could ease this inhuggingface_hubupload_folderwithignore_patternsto filterREADMEand.gitfiles. Makes implementation cleaner + only 1 commit is pushed to HF instead of 1 per file.Not done in the PR but I guess it could be interesting to add more options in the GH action like
create_pr,revision,ignore_patterns. Let's see if it's requested by community :)