Parsing HTTP Code according to RFC #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP uses \r\n for new line - fixes error with some 500 responses
|
I agree. That parsing method is overkill. Should just look for the first int. Merging in for now to accomodate the main issue for now. |
nategood
added a commit
that referenced
this pull request
Mar 5, 2013
Parsing HTTP Code according to RFC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have encountered this error during testing mine apps communicating over HTTP.
Mine setup was Nginx + PHP 5.4.12 on Win.
On 500 response status was not parsed properly and Httpful threw an exception.
I still don't fully get how the http code parsing could work without this patch so I would appreciate if someone could revise the proposed change.
I can provide testing data for exception if necessary (don't have time right now).
OT: Anyhow I would expect from this library to take more simpler approach by checking for number till first space. (checking only for
500instead of `500 Server Error...\n')