Resubmit pull request... on request #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow running phpunit in tests folder alone. Generate coverage report.
Headers should end in CRLF make them so.
So that diff may stap complaining about missing new lines.
Test changes made to Accept and User Agent headers.
Test changes made to hasErrors , raw_headers, _parseHeaders. Additional tests against __toString and _parseCode in an attempt to get the coverage up.
Although not implicitly required added for completion.
Only status codes 4xx and 5xx should be considered errors. 1xx are informational and therefor not an error.
As per 2616 headers should end in CRLF parser should handle it appropriately. Additional headers are optional and prser should consider not getting headers to parse.
Compose an User-Agent header by collecting available information. This behaviour can be ommitted by adding a custom User-Agent request header.
If you can coneg against this Accept: header you can mark your implementation passed. Contains all the legal LWS. Preferable mime types are listed in reverse order, expected mime-type is added to the end. The order the server should sort these in are as follows 1 expected/type 0.9 text/html;level=3 0.8 text/plain 0.5 *.* This will also prevent you from getting 406 Not Acceptable errors.
Mainly done to be able to test against the composed header without a bajor refactor. This is now similar to the response and although there are other ways to get this information from cURL this now makes HttpFul complete being able to provide both request and response headers. Note the HTTP version is hard coded this might require additional work but should be efficient for the majority of use cases.
nategood
pushed a commit
that referenced
this pull request
Jun 20, 2012
Resubmit pull request... on request
|
DAmn I just fixed the white space =/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitted to dev branch as per #34