Templating broken with unset #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response\Headers lowercases header names.
Before header names were only lowercased when created by fromString.
I'm using the Typo3 Flow framework, that creates proxies for all classes. The proxy is created by extending the Request-class and overrides the constructor. It initializes the original Request-class by calling parent::__construct, but the private __construct method is not in scope. Instead the constructor should be marked as protected.
Added cURL error number and message to exception to avoid parsing exception message later on
Solves issue nategood#170: HTTP Header parsing is inconsistent
Fix download link
Typo correction
nategood#227 unset curl handle after it has been closed
ConnectionErrorException cURLError
added support for http_proxy environment variable
Fix for frameworks that use object proxies
Add PHPDocs for __call methods in Request.
PHPUnit Fixes and officially drop < 7.2
fix: header casing issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests had a statement, at the end of the
sendmethod, tounset($this->_ch). $_ch holds the curl object. Under PHP 8.x, accessing/setting undefined class properties throws a warning. So when using the template abilities, subsequent send operations would generate a warning. The fix was to set$this->_ch = null;.