Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to interrupt Pan #61

Closed
Tadaboody opened this issue Nov 19, 2018 · 6 comments
Closed

Unable to interrupt Pan #61

Tadaboody opened this issue Nov 19, 2018 · 6 comments
Labels
is:bug

Comments

@Tadaboody
Copy link

Tadaboody commented Nov 19, 2018 •
edited
Loading

Steps to produce:

  1. Pan fast
  2. Press view to stop panning

Excepted behaviour:

  • Pan immediately stops, and the view isn't tapped

Current behaviour:

  • Nothing, the pan just continues and doesn't respond to tap
@natario1
Copy link
Owner

Thank you, it doesn't work indeed

@Tadaboody
Copy link
Author

Now that #38 is merged I feel more confident trying to tackle this - expect an early PR this week

@markusressel
Copy link
Collaborator

Is this a bug introduced by #38?

@Tadaboody
Copy link
Author

@markusressel No but I wanted to wait for it to be merged because I prefer to work on Kotlin

markusressel added a commit that referenced this issue Jan 4, 2019
@markusressel
cancel any currently running animation when touching the screen - fixes
22ad009 
#61

renamed function to match its usecase
use androids ValueAnimator for animations instead of pure Runnables and manual interpolation
@Tadaboody
Copy link
Author

Completely forgot about this so sorry 🙏 thanks for the fix @markusressel

@markusressel
Copy link
Collaborator

@Tadaboody no problem, hope it works 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tadaboody @markusressel @natario1