Fix more leaks

natario1 · Mar 4, 2019 · 3a91345 · 3a91345
1 parent d940a28
commit 3a91345
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/library/src/main/kotlin/com/otaliastudios/elements/Adapter.kt b/library/src/main/kotlin/com/otaliastudios/elements/Adapter.kt
@@ -276,6 +276,7 @@ public final class Adapter private constructor(
             it.unbind(this)
         }
         recyclerViews.clear()
+        lifecycle.removeObserver(this)
     }
 
     /**

diff --git a/library/src/main/kotlin/com/otaliastudios/elements/extensions/DataBindingPresenter.kt b/library/src/main/kotlin/com/otaliastudios/elements/extensions/DataBindingPresenter.kt
@@ -33,6 +33,7 @@ abstract class DataBindingPresenter<T: Any, DB: ViewDataBinding>(
             @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
             fun onDestroy() {
                 binding.setLifecycleOwner(null)
+                lifecycle.removeObserver(this)
             }
         })
         return holder
-Original file line number
+Diff line change
@@ Expand Up / @@ -276,6 +276,7 @@ public final class Adapter private constructor( @@
                 it.unbind(this)
             }
             recyclerViews.clear()
+            lifecycle.removeObserver(this)
         }
         /**
@@ Expand Down @@