Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -C and --directory for pyproject.toml directory path (#212) #213

Merged

Conversation

jeraymond
Copy link
Contributor

Update Poe to use args -C and --directory to find the path to the directory with pyproject.toml. This better aligns with Poetry (which also uses -C and --directory). Keep the --root argument as a hidden parameter for backwards compatibility.

@jeraymond
Copy link
Contributor Author

@nat-n I think I found the right places to swap in -C for --root (ui, tests, docs). Please take a look and LMK if I missed anything.

Copy link
Owner

@nat-n nat-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution! Could you please target the PR to the development branch?\

also looks like you need to run poe format

docs/guides/help_guide.rst Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
Update Poe to use args -C and --directory to find the path to the directory
with pyproject.toml. This better aligns with Poetry (which also uses -C and
--directory). Keep the --root argument as a hidden parameter for backwards
compatibility.
@jeraymond jeraymond force-pushed the fix-212-consistent-working-directory-flags branch from a2a4413 to 6b35be6 Compare April 20, 2024 21:03
@jeraymond jeraymond changed the base branch from main to development April 20, 2024 21:04
Copy link
Contributor Author

@jeraymond jeraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the command help alignment and formatting. Also ran poe check so I think it should be good now, formatting an all. I changed the base to the development branch.

docs/guides/help_guide.rst Show resolved Hide resolved
Copy link
Owner

@nat-n nat-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. I just noticed another typo.

poethepoet/ui.py Outdated Show resolved Hide resolved
docs/guides/help_guide.rst Outdated Show resolved Hide resolved
@nat-n
Copy link
Owner

nat-n commented Apr 21, 2024

@jeraymond Thanks for helping to make poethepoet better :)

@nat-n nat-n merged commit 57ea176 into nat-n:development Apr 21, 2024
19 checks passed
@jeraymond
Copy link
Contributor Author

@jeraymond Thanks for helping to make poethepoet better :)

No problem, thanks for making such a great tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants