Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mushe #265

Closed
wants to merge 7 commits into from
Closed

Mushe #265

wants to merge 7 commits into from

Conversation

MusheAbdulHakim
Copy link

Filemananger for users to manager their files.

@nasirkhan
Copy link
Owner

@MusheAbdulHakim ,
Thank you for submitting the pull request.

Here you added the unisharp/laravel-filemanager package and related files. It is a great package and I used it before, But i moved from there as it was not updating/ fixing the issues regularly.

alexusmai/laravel-file-manager package is installed here and integrated with the Posts. You may use this with other parts as well.

Now, if you please let me the advantages of your suggested package with the current one, then we may replace the existing.

@MusheAbdulHakim
Copy link
Author

Okay thanks for the feedback.

@MusheAbdulHakim
Copy link
Author

I have tried https://github.com/alexusmai/laravel-file-manager and i still think https://github.com/unisharp/laravel-filemanager is much better to it.It is very simple to use,it has nice user interface.and ultimately , you don't have struggles with styling after integration.

@MusheAbdulHakim
Copy link
Author

I will like to contribute to the project.So if there is anything i can do to help let me know.

@nasirkhan
Copy link
Owner

nasirkhan commented May 30, 2021 via email

@nasirkhan
Copy link
Owner

Hi @MusheAbdulHakim,

I was trying to merge this pull request today and found one issue on the admin/filemanager page. From the page source i found that the google analytics code has been added twice on the page and that throwing an error in the console. Can you please look into that?

@MusheAbdulHakim
Copy link
Author

ok i will look into that

@MusheAbdulHakim
Copy link
Author

@nasirkhan I have checked and i haven't seen anything like what you have described.
But i can close this pull request and send a new one for you to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants