Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #166, reorganize source files #168

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix #166, reorganize source files #168

merged 2 commits into from
Nov 14, 2023

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Oct 26, 2023 •
edited
Loading

Describe the contribution
Organize source files into a directory and naming pattern that is compliant with the CFE current recommended practice.

Configurable items are moved to the respective header files and documentation is added to indicate what they do.

Fixes #166

Second commit - Add a separate "encode" step as part of TO_LAB output forwarding. Initially, this is just a pass through implementation, so it matches current behavior.

Fixes #167

Testing performed
Build and run, sanity check

Expected behavior changes
None

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 26, 2023
View reviewed changes
fsw/src/to_lab_app.c Fixed Show fixed Hide fixed
fsw/src/to_lab_cmds.c Fixed Show fixed Hide fixed
fsw/src/to_lab_cmds.c Fixed Show fixed Hide fixed
fsw/src/to_lab_cmds.c Fixed Show fixed Hide fixed
fsw/src/to_lab_cmds.c Fixed Show fixed Hide fixed
fsw/src/to_lab_cmds.c Fixed Show fixed Hide fixed
fsw/src/to_lab_dispatch.c
}
}

void TO_LAB_TaskPipe(const CFE_SB_Buffer_t *SBBufPtr)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_dispatch.c
/* TO_LAB_ProcessGroundCommand() -- Process local message */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
void TO_LAB_ProcessGroundCommand(const CFE_SB_Buffer_t *SBBufPtr)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_cmds.c

/* initialize the packet data */
TO_LAB_Global.DataTypesTlm.Payload.synch = 0x6969;
#if 0

Check notice

Code scanning / CodeQL

Conditional compilation Note

Use of conditional compilation must be kept to a minimum.
@jphickey
Fix nasa#166, reorganize source files
ae2fcee 
Organize source files into a directory and naming pattern that is
compliant with the CFE current recommended practice.

Configurable items are moved to the respective header files and
documentation is added to indicate what they do.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 1, 2023
View reviewed changes
fsw/src/to_lab_cmds.c
/* TO_LAB_RemoveAll() -- Remove All Packets */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t TO_LAB_RemoveAllCmd(const TO_LAB_RemoveAllCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_cmds.c
/* TO_LAB_RemovePacket() -- Remove Packet */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t TO_LAB_RemovePacketCmd(const TO_LAB_RemovePacketCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_cmds.c
/* TO_LAB_AddPacket() -- Add packets */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t TO_LAB_AddPacketCmd(const TO_LAB_AddPacketCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_cmds.c
/* TO_LAB_SendDataTypes() -- Output data types */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t TO_LAB_SendDataTypesCmd(const TO_LAB_SendDataTypesCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
fsw/src/to_lab_cmds.c
/* TO_LAB_EnableOutput() -- TLM output enabled */
/* */
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
CFE_Status_t TO_LAB_EnableOutputCmd(const TO_LAB_EnableOutputCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 1, 2023
@jphickey
Fix nasa#167, add encode hook
511a3dc 
Add a separate "encode" step as part of TO_LAB output forwarding.
Initially, this is just a pass through implementation, so it matches
current behavior.
@jphickey jphickey mentioned this pull request Nov 2, 2023
Closed
@dzbaker dzbaker added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Nov 2, 2023
@dzbaker dzbaker mentioned this pull request Nov 13, 2023
Merged
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 13, 2023
@dzbaker
IC: Caelum-rc4+dev64
4af773f 
*Combines:*

sch_lab v2.5.0-rc4+dev71
sample_app v1.3.0-rc4+dev65
to_lab v2.5.0-rc4+dev66
ci_lab v2.5.0-rc4+dev69
cFE v7.0.0-rc4+dev411
PSP v1.6.0-rc4+dev96

**Includes:**

*sch_lab*
- nasa/sch_lab#129
- nasa/sch_lab#149
- nasa/sch_lab#142
- nasa/sch_lab#134

*sample_app*
- nasa/sample_app#212
- nasa/sample_app#187
- nasa/sample_app#190

*to_lab*
- nasa/to_lab#168
- nasa/to_lab#134
- nasa/to_lab#146
- nasa/to_lab#148
- nasa/to_lab#152
- nasa/to_lab#158
- nasa/to_lab#163

*ci_lab*
- nasa/ci_lab#152
- nasa/ci_lab#153

*cFE*
- nasa/cFE#2462
- nasa/cFE#2408

*PSP*
- nasa/PSP#417

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Isaac Rowe <[email protected]>
Co-authored by: Jacob Hageman  <[email protected]>
@dzbaker dzbaker mentioned this pull request Nov 13, 2023
Merged
2 tasks
@dzbaker dzbaker merged commit f763010 into nasa:main Nov 14, 2023
11 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2023
@dzbaker
IC: Caelum-rc4+dev64
ae31951 
*Combines:*

sch_lab v2.5.0-rc4+dev71
sample_app v1.3.0-rc4+dev65
to_lab v2.5.0-rc4+dev66
ci_lab v2.5.0-rc4+dev69
cFE v7.0.0-rc4+dev411
PSP v1.6.0-rc4+dev96

**Includes:**

*sch_lab*
- nasa/sch_lab#129
- nasa/sch_lab#149
- nasa/sch_lab#142
- nasa/sch_lab#134

*sample_app*
- nasa/sample_app#212
- nasa/sample_app#187
- nasa/sample_app#190

*to_lab*
- nasa/to_lab#168
- nasa/to_lab#134
- nasa/to_lab#146
- nasa/to_lab#148
- nasa/to_lab#152
- nasa/to_lab#158
- nasa/to_lab#163

*ci_lab*
- nasa/ci_lab#152
- nasa/ci_lab#153

*cFE*
- nasa/cFE#2462
- nasa/cFE#2408

*PSP*
- nasa/PSP#417

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Isaac Rowe <[email protected]>
Co-authored by: Jacob Hageman  <[email protected]>
@jphickey jphickey deleted the fix-166-reorg branch November 16, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hooks for encoding/translating of network buffer Update directory structure to follow current convention
2 participants
@jphickey @dzbaker