Fix #152, adjust subscription table based on apps present #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an inclusion preprocessor macro for each app referred to in the subscription table, and only include that line if the app is present in the current configuration. In particular, do not assume that sample_app will always be there.
jphickey
added
the
CCB:Ready
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
dzbaker
added
CCB:Approved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Create an inclusion preprocessor macro for each app referred to in the subscription table, and only include that line if the app is present in the current configuration.
In particular, do not assume that sample_app will always be there.
Fixes #152
Testing performed
Build TO_LAB without SAMPLE_APP and confirm successful
Expected behavior changes
Presence of other apps is not assumed/hardcoded in the subscription table
System(s) tested on
Debian
Additional context
This should fix workflow errors where apps are built with TO_LAB but without SAMPLE_APP.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.