Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #121, Remove registration of empty EVS filters #122

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix #121, Remove registration of empty EVS filters #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions fsw/src/to_lab_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,6 @@ TO_LAB_GlobalData_t TO_LAB_Global;

TO_LAB_Subs_t * TO_LAB_Subs;
CFE_TBL_Handle_t TO_SubTblHandle;
/*
** Event Filter Table
*/
static CFE_EVS_BinFilter_t CFE_TO_EVS_Filters[] = {/* Event ID mask */
{TO_INIT_INF_EID, 0x0000}, {TO_CRCMDPIPE_ERR_EID, 0x0000},
{TO_SUBSCRIBE_ERR_EID, 0x0000}, {TO_TLMOUTSOCKET_ERR_EID, 0x0000},
{TO_TLMOUTSTOP_ERR_EID, 0x0000}, {TO_MSGID_ERR_EID, 0x0000},
{TO_FNCODE_ERR_EID, 0x0000}, {TO_NOOP_INF_EID, 0x0000}};

/*
** Prototypes Section
Expand Down Expand Up @@ -152,10 +144,9 @@ int32 TO_LAB_init(void)
strcpy(ToTlmPipeName, "TO_LAB_TLM_PIPE");

/*
** Register event filter table...
** Register with EVS
*/
CFE_EVS_Register(CFE_TO_EVS_Filters, sizeof(CFE_TO_EVS_Filters) / sizeof(CFE_EVS_BinFilter_t),
CFE_EVS_EventFilter_BINARY);
CFE_EVS_Register(NULL, 0, CFE_EVS_EventFilter_BINARY);

Check warning

Code scanning / CodeQL

Unchecked return value

The return value of non-void function [CFE_EVS_Register](1) is not checked.
/*
** Initialize housekeeping packet (clear user data area)...
*/
Expand Down