Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for suggested alignment enforcement pattern (nasa/cFE#1009) #66

Closed
skliper opened this issue Nov 17, 2020 · 0 comments · Fixed by #69 or #70
Closed

Update for suggested alignment enforcement pattern (nasa/cFE#1009) #66

skliper opened this issue Nov 17, 2020 · 0 comments · Fixed by #69 or #70
Labels
enhancement New feature or request
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Nov 17, 2020

Is your feature request related to a problem? Please describe.
See nasa/cFE#1009, inconsistent pattern

Describe the solution you'd like
Match suggestion in nasa/cFE#1009, use the "raw" message cmd/tlm types in definition.

Describe alternatives you've considered
None

Additional context
nasa/cFE#1009

Requester Info
Jacob Hageman - NASA/GSFC
skliper added a commit to skliper/to_lab that referenced this issue Nov 30, 2020
@skliper
Fix nasa#66, Implement message alignment pattern
5eb6d0b 
- Replace CFE_SB_RcvMsg with CFE_SB_ReceiveBuffer
- Use CFE_SB_Buffer_t for receiving and casting to command types
- Use CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t in
  command and telemetry type definitions
- Use CFE_SB_TransmitMsg_t to copy the command and telemetry
  into a CFE_SB_Buffer_t and send it where needed
- Avoids need to create send buffers within the app (or union
  the packet types with CFE_SB_Buffer_t)
- Eliminates references to CFE_SB_CmdHdr_t and CFE_SB_TlmHdr_t
  that formerly enforced alignment since these had potential
  to change the actual packet sizes
- No need to cast to CFE_MSG_Message_t anywhere since it's
  available in the CFE_SB_Buffer_t union
- Replaced CFE_MSG_Size_t with size_t
skliper added a commit to skliper/to_lab that referenced this issue Nov 30, 2020
@skliper
Fix nasa#66, Implement message alignment pattern
3f7e1df 
- Replace CFE_SB_RcvMsg with CFE_SB_ReceiveBuffer
- Use CFE_SB_Buffer_t for receiving and casting to command types
- Use CFE_MSG_CommandHeader_t and CFE_MSG_TelemetryHeader_t in
  command and telemetry type definitions
- Use CFE_SB_TransmitMsg to copy the command and telemetry
  into a CFE_SB_Buffer_t and send it where needed
- Avoids need to create send buffers within the app (or union
  the packet types with CFE_SB_Buffer_t)
- Eliminates references to CFE_SB_CmdHdr_t and CFE_SB_TlmHdr_t
  that formerly enforced alignment since these had potential
  to change the actual packet sizes
- No need to cast to CFE_MSG_Message_t anywhere since it's
  available in the CFE_SB_Buffer_t union
- Replaced CFE_MSG_Size_t with size_t
@skliper skliper mentioned this issue Nov 30, 2020
Merged
@astrogeco astrogeco added this to the 2.5.0 milestone Dec 8, 2020
@astrogeco astrogeco added the enhancement New feature or request label Dec 8, 2020
astrogeco added a commit that referenced this issue Dec 8, 2020
@astrogeco
Merge pull request #69 from skliper/fix66-alignment-pattern
8832382 
Fix #66, Implement message alignment pattern
@astrogeco astrogeco mentioned this issue Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco