Subscribes to MsgId 0x0 256-actual_msgids times

[skliper]

Describe the bug
Loops through the entire table of subscriptions and subscribes, any unset values in the table are 0 so subscribes to MsgId 0 over 200 times.

Shows up multiple times on startup:
EVS Port1 42/1/CFE_SB 7: Duplicate Subscription,MsgId 0x0 on TO_LAB_TLM_PIPE pipe,app TO_LAB_APP

To Reproduce
Any normal run.

Expected behavior
Only subscribe to requested message IDs.

Code snips

to_lab/fsw/src/to_lab_app.c

Lines 227 to 238 in 5adf513

	/* Subscriptions for TLM pipe*/
	for (i = 0; (i < (sizeof(TO_LAB_Subs->Subs) / sizeof(TO_LAB_Subs->Subs[0]))); i++)
	{
	if (CFE_SB_IsValidMsgId(TO_LAB_Subs->Subs[i].Stream))
	status = CFE_SB_SubscribeEx(TO_LAB_Subs->Subs[i].Stream, TO_LAB_Global.Tlm_pipe, TO_LAB_Subs->Subs[i].Flags,
	TO_LAB_Subs->Subs[i].BufLimit);
	if (status != CFE_SUCCESS)
	CFE_EVS_SendEvent(TO_SUBSCRIBE_ERR_EID, CFE_EVS_EventType_ERROR,
	"L%d TO Can't subscribe to stream 0x%x status %i", __LINE__,
	(unsigned int)CFE_SB_MsgIdToValue(TO_LAB_Subs->Subs[i].Stream), (int)status);
	}

System observed on:

• Hardware: cFS Dev 3
• OS: Ubuntu 18.04
• Versions: current bundle

Additional context
Likely due to subscription table conversion to a cFS table.

Reporter Info
Jacob Hageman - NASA/GSFC