Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to "CCSDS" structures #41

Closed
jphickey opened this issue May 28, 2020 · 0 comments · Fixed by #42 or #44
Closed

Remove references to "CCSDS" structures #41

jphickey opened this issue May 28, 2020 · 0 comments · Fixed by #42 or #44
Assignees
@jphickey
Labels
bug Something isn't working
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Applications should NOT refer to the "CCSDS" data types and macros, as there should be no assumption of a particular message framing type at this level.

Describe the solution you'd like
Use the abstract types provided in cfe_sb.h rather than directly using ccsds.h types.

Additional context
Related to nasa/cFE#554

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/to_lab that referenced this issue May 28, 2020
@jphickey
Fix nasa#41, remove dependencies on CCSDS types
9ccbc32 
Applications should only use types provide by CFE_SB.
@jphickey jphickey mentioned this issue May 28, 2020
Merged
@skliper skliper added this to the 2.4.0 milestone May 29, 2020
@skliper skliper added the enhancement New feature or request label May 29, 2020
jphickey added a commit to jphickey/to_lab that referenced this issue Jun 3, 2020
@jphickey
Fix nasa#41, remove dependencies on CCSDS types
862a9ee 
Applications should only use types provide by CFE_SB.
astrogeco added a commit that referenced this issue Jun 3, 2020
@astrogeco
Merge pull request #42 from jphickey/fix-41-ccsds-refs
491e2ce 
Fix #41, remove dependencies on CCSDS types
@astrogeco astrogeco mentioned this issue Jun 10, 2020
Merged
@astrogeco astrogeco added bug Something isn't working and removed enhancement New feature or request labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug Something isn't working
Projects
None yet
Milestone
Bootes
3 participants
@jphickey @skliper @astrogeco