Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary/confusing TO_LAB_UNUSED #159

Closed
skliper opened this issue Sep 13, 2023 · 0 comments · Fixed by #160
Closed

Unnecessary/confusing TO_LAB_UNUSED #159

skliper opened this issue Sep 13, 2023 · 0 comments · Fixed by #160
Assignees

Comments

@skliper
Copy link
Contributor

skliper commented Sep 13, 2023

Is your feature request related to a problem? Please describe.
The only two places TO_LAB_UNUSED is referenced:

#define TO_LAB_UNUSED CFE_SB_MSGID_RESERVED

and

to_lab/fsw/src/to_lab_app.c

Lines 205 to 209 in 81d85da

if (!CFE_SB_IsValidMsgId(TO_LAB_Subs->Subs[i].Stream))
{
/* Only process until invalid MsgId (aka TO_LAB_UNUSED) is found*/
break;
}

Since the test is for a valid msgid, it can only be CFE_SB_MSGID_RESERVED.

Describe the solution you'd like
Remove TO_LAB_UNUSED

Describe alternatives you've considered
None

Additional context
Old custom to subs table file was using it, but since it's in to_lab_app.h it's not really exposed. Just remove to avoid this potential confusion in the future.

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper self-assigned this Sep 13, 2023
dzbaker added a commit that referenced this issue Sep 14, 2023
Fix #159, Remove unused/unnecessary TO_LAB_UNUSED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant