Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows overly restrictive run, missing duplicate check, format job name incorrect, remove --quiet from cppcheck #109

Closed
skliper opened this issue Oct 22, 2021 · 1 comment
Closed

Workflows overly restrictive run, missing duplicate check, format job name incorrect, remove --quiet from cppcheck #109

skliper opened this issue Oct 22, 2021 · 1 comment
Labels
continuous-integration duplicate This issue or pull request already exists

Comments

@skliper
Copy link
Contributor

skliper commented Oct 22, 2021

Is your feature request related to a problem? Please describe.
Branch restriction unnecessary:

to_lab/.github/workflows/codeql-build.yml

Lines 3 to 7 in 0c6d816

on:
push:
pull_request:
branches:
- main

Branch restriction unnecessary, missing duplicate check, incorrect job name:

to_lab/.github/workflows/format-check.yml

Lines 4 to 12 in 0c6d816

on:
push:
branches:
- main
pull_request:
jobs:
static-analysis:

Branch restriction unnecessary, missing duplicate check:

to_lab/.github/workflows/static-analysis.yml

Lines 4 to 12 in 0c6d816

on:
push:
branches:
- main
pull_request:
jobs:
static-analysis:

Remove --quiet flag to report files processed:

to_lab/.github/workflows/static-analysis.yml

Line 26 in 0c6d816

run: cppcheck --force --inline-suppr --quiet . 2> cppcheck_err.txt

Describe the solution you'd like
Fix

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper changed the title Workflows overly restrictive run, missing duplicate check, format job name incorrect, remove --quite from cppcheck Workflows overly restrictive run, missing duplicate check, format job name incorrect, remove --quiet from cppcheck Oct 22, 2021
@skliper skliper added the duplicate This issue or pull request already exists label Oct 28, 2021
@skliper
Copy link
Contributor Author

skliper commented Oct 28, 2021

OBE - #110

@skliper skliper closed this as completed Oct 28, 2021
jphickey added a commit to jphickey/to_lab that referenced this issue Apr 6, 2023
@jphickey
Fix nasa#109, update cmake recipe
37da7be 
Prefer target-scope properties over directory scope where applicable
jphickey added a commit to jphickey/to_lab that referenced this issue Apr 6, 2023
@jphickey
Fix nasa#109, update cmake recipe
522fac3 
Prefer target-scope properties over directory scope where applicable
@jphickey jphickey mentioned this issue Apr 6, 2023
Merged
jphickey added a commit to jphickey/to_lab that referenced this issue Apr 6, 2023
@jphickey
Fix nasa#109, update cmake recipe
20b7fb6 
Prefer target-scope properties over directory scope where applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous-integration duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skliper