Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19, Change full word help option '-help' to '--help' #24

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

martintc
Copy link
Contributor

@martintc martintc commented Oct 31, 2020

Describe the contribution
Fix #19

Change the command line argument to '--help' instead of '-help' as per issue #19

Testing performed
Compiled with GCC-9 and clang, no compile errors and behavior remains the same.

Expected behavior changes
Only behavior change is the program expects --help instead of -help

System(s) tested on

  • Hardware: Macbook Pro 2015
  • OS: Mac OS 10.15.7
  • OS: Ubuntu 20.04 (in vm)

Contributor Info - All information REQUIRED for consideration of pull request
Todd Martin, personal

@skliper skliper linked an issue Nov 2, 2020 that may be closed by this pull request
@skliper skliper added CCB:PendingCLA External contribution pending CLA confirmation CCB:FastTrack labels Nov 2, 2020
@martintc
Copy link
Contributor Author

martintc commented Nov 2, 2020

For the CLA, I just fill out the form and email it to the email address listed at the bottom? First code commit to NASA's github.

@astrogeco
Copy link
Contributor

Hi @martintc thank you for your contribution. Could you sign and email the appropriate Contributor License agreement?

email it to: [email protected] and copy [email protected]

Thanks

@martintc
Copy link
Contributor Author

martintc commented Feb 3, 2021

@astrogeco Signed license agreement has been sent to the email addresses as requested.

@astrogeco
Copy link
Contributor

@astrogeco Signed license agreement has been sent to the email addresses as requested.

Got it, really appreciate it!

@astrogeco astrogeco removed the CCB:PendingCLA External contribution pending CLA confirmation label Feb 3, 2021
@astrogeco astrogeco changed the title Changed full word help option '-help' to '--help' as per issue #19. Fix #19, Changed full word help option '-help' to '--help' Feb 3, 2021
@astrogeco
Copy link
Contributor

One more ask, could you amend your commit message to read as follows?

Fix #19, Change full word help option '-help' to '--help'

@martintc martintc changed the title Fix #19, Changed full word help option '-help' to '--help' Fix #19, Change full word help option '-help' to '--help' Feb 6, 2021
@martintc
Copy link
Contributor Author

martintc commented Feb 6, 2021

Made the change, hope that is the change that was requested

@astrogeco astrogeco changed the base branch from main to integration-candidate February 8, 2021 16:58
@astrogeco astrogeco merged commit 590b8e4 into nasa:integration-candidate Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix input options handling dashes
4 participants