Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration candidate 20190916 #12

Closed
wants to merge 0 commits into from
Closed

Integration candidate 20190916 #12

wants to merge 0 commits into from

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 16, 2019

Describe the contribution
Merge of CCB 20190904 approved commits.
Fixes #1, fixes #2, fixes #10

Testing performed
Steps taken to test the contribution:

  1. Checked out https://github.com/nasa/cFS rc-6.7.0 and followed setup instructions
  2. Followed standard build instructions
  3. Executed cfe_ts_crc from build/exe/host with no input, observed:
cFE TS CRC calculator for LRO files.
Usage: cfe_ts_crc [filename]
  1. Executed cfe_ts_crc on random file observed:
Table File Name:            cmdUtil
Table Size:                 25684 Bytes
Expected TS Validation CRC: 0xFFFFC2E8

Expected behavior changes

  • No impact to behavior from this change other than now builds as part of cmake

System(s) tested on:

  • cFS Development Server
  • OS: Ubuntu/Linux 4.4.0-146-generic
  • Versions: bundle release candidate 6.7 with this branch

Additional context
None

Contributor Info
Jacob Hageman/NASA

Community contributors
CLA on file

@skliper
Copy link
Contributor Author

skliper commented Sep 16, 2019

Just to checksum a more stable file (for comparison reasons):

Table File Name:            ../../../tools/tblCRCTool/LICENSE-18128-Apache-2_0.pdf
Table Size:                 95219 Bytes
Expected TS Validation CRC: 0x00004BFE

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@skliper
Copy link
Contributor Author

skliper commented Oct 1, 2019

Forced the message amend to note CCB has reviewed.

@skliper skliper mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants