Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read failures are not handled #36

Closed
skliper opened this issue Mar 1, 2021 · 0 comments · Fixed by #42
Closed

read failures are not handled #36

skliper opened this issue Mar 1, 2021 · 0 comments · Fixed by #42
Assignees
@zanzaben
Labels
enhancement New feature or request
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 1, 2021

Is your feature request related to a problem? Please describe.
There's a coercion alters value static analysis warning on for readSize:

tblCRCTool/cfe_ts_crc.c

Lines 136 to 137 in b02864b

readSize = read(fd, buffer, 100);
fileCRC = CalculateCRC(buffer, readSize, fileCRC);

Describe the solution you'd like
Handle an error from read

Describe alternatives you've considered
None

Additional context
Static analysis warning

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Mar 1, 2021
@skliper skliper added this to the 1.3.0 milestone Mar 1, 2021
zanzaben added a commit to zanzaben/tblCRCTool that referenced this issue Mar 1, 2021
@zanzaben
Fix nasa#36, handle read failure
c3277d5
@zanzaben zanzaben mentioned this issue Mar 1, 2021
Closed
zanzaben added a commit to zanzaben/tblCRCTool that referenced this issue Mar 3, 2021
@zanzaben
Fix nasa#36, handle read failure
e90d4a8
@zanzaben zanzaben mentioned this issue Mar 4, 2021
Merged
zanzaben added a commit to zanzaben/tblCRCTool that referenced this issue Mar 4, 2021
@zanzaben
Fix nasa#36 nasa#38 nasa#40 nasa#41
96bbc6b 
36: Handle read failure
38: handle lseek error
40: use exit (1)
41: fix EOF check
zanzaben added a commit to zanzaben/tblCRCTool that referenced this issue Mar 5, 2021
@zanzaben
Fix nasa#36 nasa#38 nasa#40 nasa#41
10db681 
36: Handle read failure
38: handle lseek error
40: use exit (1)
41: fix EOF check
zanzaben added a commit to zanzaben/tblCRCTool that referenced this issue Mar 5, 2021
@zanzaben
Fix nasa#36 nasa#38 nasa#40 nasa#41
05f8652 
36: Handle read failure
38: handle lseek error
40: use exit (1)
41: fix EOF check
@skliper skliper closed this as completed in 558b20c Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
enhancement New feature or request
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @skliper