Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeQL analysis to workflow #33

Closed
skliper opened this issue Feb 8, 2021 · 0 comments · Fixed by #34 or #35
Closed

Add CodeQL analysis to workflow #33

skliper opened this issue Feb 8, 2021 · 0 comments · Fixed by #34 or #35
Labels
continuous-integration enhancement New feature or request security
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Feb 8, 2021

Is your feature request related to a problem? Please describe.
CodeQL analysis not implemented in submodules

Describe the solution you'd like
Add so alerts are generated on pull requests to submodules

Describe alternatives you've considered
None

Additional context
CodeQL is run at the bundle (nasa/cFS) level, but link to code in submodules doesn't work.

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Feb 8, 2021
@skliper skliper added this to the 1.3.0 milestone Feb 8, 2021
skliper added a commit to skliper/tblCRCTool that referenced this issue Feb 8, 2021
@skliper
Fix nasa#33, Add CodeQL analysis to workflow
1245c41
@skliper skliper mentioned this issue Feb 8, 2021
Merged
@astrogeco astrogeco added continuous-integration enhancement New feature or request security and removed enhancement New feature or request labels Feb 12, 2021
astrogeco added a commit that referenced this issue Feb 12, 2021
@astrogeco
Merge pull request #34 from skliper/fix33-add_codeql
8cbfcd3 
Fix #33, Add CodeQL analysis to workflow
@astrogeco astrogeco mentioned this issue Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
continuous-integration enhancement New feature or request security
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco