Fix #37, Opaque CFE_SB_MsgId_t values #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-37-opaque-msgid
branch
from
3cc2bec
to
ab469df
Compare
|
Related to nasa/cFE#592 |
|
CCB 20200408 - Split up into parts. |
astrogeco
added
CCB - 20200408
and removed
CCB:Ready
astrogeco
suggested changes
Apr 8, 2020
|
Reviving this -- necessary to fix compile errors with RTEMS and extended headers enabled. There was nothing to update in this app (SCH_LAB). Same commit as previous review. |
jphickey
added
CCB:Ready
|
CCB 20200506 - APPROVED |
astrogeco
added
CCB-20200506
and removed
CCB:Ready
Do not assume CFE_SB_MsgId_t is implicitly integral in nature. When an integer value is required for printing or backward compatibility, use the explicit conversion routine to get this.
jphickey
force-pushed
the
fix-37-opaque-msgid
branch
from
ab469df
to
c6f0ef5
Compare
|
Correction - this is almost the same, but the MID constants do not have a _VALUE suffix since the constants did not change names. |
skliper
approved these changes
May 8, 2020
astrogeco
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Apply the
CFE_SB_MsgIdToValue()andCFE_SB_ValueToMsgId()routines where compatibility with an integer MsgId is necessary - syslog prints, events, compile-time MID#definevalues.Fixes #37
Testing performed
Unit test
Execute CFE and sanity-check normal operation - send commands to app using
cmdUtiland confirm commands are processed normally.Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 18.04 LTS, 64-bit
Additional context
In future versions of CFE SB the MsgId type might not be a simple integer, so this is one step in the direction of avoiding this assumption in apps.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.