Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE_ES_ExitApp called with internal status control parameter rather than RunStatus #148

Closed
2 tasks done
thnkslprpt opened this issue Sep 27, 2023 · 0 comments · Fixed by #149
Closed
2 tasks done

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
The call to CFE_ES_ExitApp in SCH_Lab_AppMain is called with the internal status control parameter, but I believe CFE_ES_ExitApp is expecting the RunStatus variable instead.

This means when a command is given to sch_lab that causes CFE_ES_ExitApp to be called (e.g. CFE_ES_RestartApp) it will report an error via this path in CFE_ES_ExitApp:
https://github.com/nasa/cFE/blob/c1aa16ae647f6ec4b2f23175a120be29034b8462/modules/es/fsw/src/cfe_es_api.c#L352-L358

Code snips

CFE_ES_ExitApp(Status);

Expected behavior
Call CFE_ES_ExitApp with the RunStatus argument.

Reporter Info
Avi Weiss   @thnkslprpt

dzbaker added a commit that referenced this issue Nov 13, 2023
…Status

Fix #148, Call CFE_ES_ExitApp with RunStatus rather than internal status variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant