You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The default value for the SCH_LAB table directly refers to sample_app Msg ID, assuming this these app will be present. This is fine for a user who is cloning the https://github.com/nasa/cFS bundle repo, because it includes all submodules. But in other cases if sample_app is not present, the table fails to build.
This issue is now detected at configuration (CMake) time, if there is a reference to the include directories of a target that does not exist in this configuration.
To Reproduce
Notably, this change from compile to config time caused an unintended side effect- workflows for the other CFS apps seem to do this - it clones the CFS but modifies the targets.cmake configuration in such a way that it no longer includes the sample_app.
Expected behavior
Should not assume/require that sample_app will always be part of the config.
Code snips
Problematic assumption is here in the table:
Describe the bug
The default value for the SCH_LAB table directly refers to
sample_app
Msg ID, assuming this these app will be present. This is fine for a user who is cloning the https://github.com/nasa/cFS bundle repo, because it includes all submodules. But in other cases if sample_app is not present, the table fails to build.This issue is now detected at configuration (CMake) time, if there is a reference to the include directories of a target that does not exist in this configuration.
To Reproduce
Notably, this change from compile to config time caused an unintended side effect- workflows for the other CFS apps seem to do this - it clones the CFS but modifies the
targets.cmake
configuration in such a way that it no longer includes thesample_app
.Expected behavior
Should not assume/require that
sample_app
will always be part of the config.Code snips
Problematic assumption is here in the table:
sch_lab/fsw/tables/sch_lab_table.c
Line 57 in 74d1129
System observed on:
Github workflow (see https://github.com/nasa/LC/actions/runs/4681105860/jobs/8293280167)
Additional context
Same issue in to_lab, see nasa/to_lab#152
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: