Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default/Example table assumes presence of other apps #138

Closed
jphickey opened this issue Apr 12, 2023 · 0 comments · Fixed by #139
Closed

Default/Example table assumes presence of other apps #138

jphickey opened this issue Apr 12, 2023 · 0 comments · Fixed by #139

Comments

@jphickey
Copy link
Contributor

Describe the bug
The default value for the SCH_LAB table directly refers to sample_app Msg ID, assuming this these app will be present. This is fine for a user who is cloning the https://github.com/nasa/cFS bundle repo, because it includes all submodules. But in other cases if sample_app is not present, the table fails to build.

This issue is now detected at configuration (CMake) time, if there is a reference to the include directories of a target that does not exist in this configuration.

To Reproduce
Notably, this change from compile to config time caused an unintended side effect- workflows for the other CFS apps seem to do this - it clones the CFS but modifies the targets.cmake configuration in such a way that it no longer includes the sample_app.

Expected behavior
Should not assume/require that sample_app will always be part of the config.

Code snips
Problematic assumption is here in the table:

{CFE_SB_MSGID_WRAP_VALUE(SAMPLE_APP_SEND_HK_MID), 4, 0},

System observed on:
Github workflow (see https://github.com/nasa/LC/actions/runs/4681105860/jobs/8293280167)

Additional context
Same issue in to_lab, see nasa/to_lab#152

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant