Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component-specific cFE headers not required (all are pulled in by cfe.h) #133

Closed
thnkslprpt opened this issue Feb 15, 2023 · 0 comments · Fixed by #134
Closed

Component-specific cFE headers not required (all are pulled in by cfe.h) #133

thnkslprpt opened this issue Feb 15, 2023 · 0 comments · Fixed by #134

Comments

@thnkslprpt
Copy link
Contributor

Describe the bug
Copy of nasa/sample_app#194
The component-specific cFE header files (cfe_sb.h, cfe_es.h etc.) are all already pulled by the all-inclusive cfe.h.

Expected behavior
Remove unnecessary header #include's.

Code snips

sch_lab/fsw/src/sch_lab_app.c

Lines 29 to 33 in 91d3b7d

#include "cfe.h"
#include "cfe_sb.h"
#include "osapi.h"
#include "cfe_es.h"
#include "cfe_error.h"

Reporter Info
Avi Weiss @thnkslprpt
@thnkslprpt thnkslprpt mentioned this issue Feb 15, 2023
Merged
dzbaker added a commit that referenced this issue Nov 13, 2023
@dzbaker
Merge pull request #134 from thnkslprpt:fix-133-remove-component-spec…
437a62b 
…ific-cfe-headers

Fix #133, Remove component-specific cFE header #includes
@dzbaker dzbaker mentioned this issue Nov 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #133, Remove component-specific cFE header #includes thnkslprpt/sch_lab
1 participant
@thnkslprpt