Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub for include <> vs "" use (<> should be system only) #51

Closed
skliper opened this issue Mar 12, 2021 · 0 comments · Fixed by #54 or #55
Closed

Scrub for include <> vs "" use (<> should be system only) #51

skliper opened this issue Mar 12, 2021 · 0 comments · Fixed by #54 or #55
Labels
enhancement New feature or request

Comments

@skliper
Copy link
Contributor

skliper commented Mar 12, 2021

Is your feature request related to a problem? Please describe.
<> used on non-system header includes. Example:

sample_lib/fsw/src/sample_lib_internal.h

Line 33 in 5ded381

#include <sample_lib.h>

Describe the solution you'd like
Full scrub/fix

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Mar 12, 2021
skliper added a commit to skliper/sample_lib that referenced this issue Mar 12, 2021
@skliper
Fix nasa#51, Use quotes for local includes
0f4c519
@skliper skliper mentioned this issue Mar 16, 2021
Merged
astrogeco added a commit that referenced this issue Mar 18, 2021
@astrogeco
Merge pull request #54 from skliper/fix51-include_quotes
78f39d2 
Fix #51, Use quotes for local includes
@astrogeco astrogeco mentioned this issue Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@skliper