Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3, Remove MKS flags #9

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Fix #3, Remove MKS flags #9

merged 1 commit into from
Sep 10, 2019

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Aug 23, 2019

Removed MKS flag for sample_app

@skliper skliper changed the title remove MKS flags Remove MKS flags, #3 Aug 23, 2019
@skliper
Copy link
Contributor

skliper commented Aug 23, 2019

Fixes #3

skliper
skliper approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference for commit messages is to include issue number, as in:

Remove MKS flags, #3

@skliper skliper added the CCB:Approved Indicates code approval by CCB label Sep 4, 2019
@avan989 avan989 changed the title Remove MKS flags, #3 Fix #3, Remove MKS flags Sep 5, 2019
@skliper skliper changed the base branch from master to merge-20190906 September 10, 2019 14:31
@skliper skliper merged commit 618df4d into nasa:merge-20190906 Sep 10, 2019
@skliper skliper added this to the 1.1.0 milestone Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Milestone
Aquila
Development

Successfully merging this pull request may close these issues.
2 participants
@avan989 @skliper